Skip to content

fix: Prevent silent field overwrite when mapping conflicting fields to PostLabelingDelay #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Devguru-codes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent silent field overwrite when mapping conflicting fields to PostLabelingDelay #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion package/src/pyaslreport/modalities/asl/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,14 @@ def _rename_fields(self, session: Dict[str, Any]) -> None:

for old_key, new_key in field_mappings.items():
if old_key in session:
session[new_key] = session[old_key]
if new_key in session and session[new_key] != session[old_key]:
import logging
logging.warning(
f"Field conflict: '{old_key}' ({session[old_key]}) maps to '{new_key}' "
f"which already has value {session[new_key]}. Retaining existing '{new_key}'."
)
else:
session[new_key] = session[old_key]
del session[old_key]

# Handle NumRFBlocks special case
Expand Down