perf: Optimize DICOM header extraction for large medical datasets (Phase 1)#29
Open
chinmayy777 wants to merge 2 commits intoOSIPI:mainfrom
Open
perf: Optimize DICOM header extraction for large medical datasets (Phase 1)#29chinmayy777 wants to merge 2 commits intoOSIPI:mainfrom
chinmayy777 wants to merge 2 commits intoOSIPI:mainfrom
Conversation
…ors and configure 100MB payload limit for BIDS uploads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a significant performance bottleneck in the
pyaslreportpackage. #28Previously,
get_dicom_header()iterated through and parsed every file in the target directory usingpydicom.dcmreadjust to populate an array, before finally reading the first file again to extract the header. For clinical datasets containing thousands of DICOM slices, this caused massive unnecessary disk I/O and memory overhead.This optimization refactors the loop to return
dcm_headerimmediately upon successfully parsing the very first valid DICOM file, turning an O(N) operation into an O(1) operation (best case).Checklist