fix: add missing D_and_Ds_swap() to 13 algorithms for consistent parameter labelling#147
Open
Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
Open
fix: add missing D_and_Ds_swap() to 13 algorithms for consistent parameter labelling#147Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
Devguru-codes wants to merge 1 commit intoOSIPI:mainfrom
Conversation
…meter labelling Add self.D_and_Ds_swap(results) call before return in ivim_fit() for: - IAR_LU_segmented_3step, IAR_LU_subtracted - PV_MUMC_biexp - OGC_AmsterdamUMC_biexp, OGC_AmsterdamUMC_biexp_segmented, OGC_AmsterdamUMC_Bayesian_biexp - OJ_GU_seg, PvH_KB_NKI_IVIMfit, TF_reference_IVIMfit - TCML_TechnionIIT_SLS, TCML_TechnionIIT_lsq_sls_lm/trf/BOBYQA This corrects mislabelled D and D* when the optimizer swaps them. Previously only 9/22 algorithms had this correction. No regressions: 1127 passed, 167 skipped, 22 xfailed, 6 xpassed.
Author
|
This PR adds the missing Previously, only 9 out of 22 Python algorithms applied this correction, leading to inconsistent parameter labelling. Changes MadeAdded
Each change is a single +1 line addition. No other code was modified. Testing/Verification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add self.D_and_Ds_swap(results) call before return in ivim_fit() for:
This corrects mislabelled D and D* when the optimizer swaps them. Previously only 9/22 algorithms had this correction.
No regressions: 1127 passed, 167 skipped, 22 xfailed, 6 xpassed.
Describe the changes you have made in this PR
A clear and concise description of what you want to happen
Link this PR to an issue [optional]
Fixes #146
Checklist