Correct salvage value calculation logic#4
Open
ariane-millot wants to merge 1 commit intoOSeMOSYS:masterfrom
Open
Correct salvage value calculation logic#4ariane-millot wants to merge 1 commit intoOSeMOSYS:masterfrom
ariane-millot wants to merge 1 commit intoOSeMOSYS:masterfrom
Conversation
Corrects the salvage value formulation. Previously, the model incorrectly applied: - The simple linear depreciation formula when discount rate > 0. - The annuity-based formula when discount rate = 0.
|
Thanks @ariane-millot for pointing this out. Also extending on your proposed change : In the current version of the model, these conditions are swapped, which would:
Test on the CLEWs Demo\res\CO2TAX from the UI
also tagging: @VedranKapor , @FraGard , @ShravanKumar23 . As a suggestion, every time the model file is updated, the new version should be tested against a standard OSeMOSYS model/data, for example, UTOPIA, check: https://github.com/OSeMOSYS/OSeMOSYS_GNU_MathProg/blob/master/tests/test_gnu_mathprog.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the salvage value formulation.
Previously, the model incorrectly applied: