Skip to content

fix: Colon splitting for custom fields#649

Merged
grace-rehn merged 4 commits intomainfrom
grace/fix-custom-field-colon-splitting
Mar 13, 2026
Merged

fix: Colon splitting for custom fields#649
grace-rehn merged 4 commits intomainfrom
grace/fix-custom-field-colon-splitting

Conversation

@grace-rehn
Copy link
Contributor

@grace-rehn grace-rehn commented Mar 12, 2026

Update the custom fields parsing to split only on first :, allowing the value to contain :s.

Tested with:

- name: Create Release with Custom Fields
  uses: OctopusDeploy/create-release-action@grace/fix-custom-field-colon-splitting
  with:
    project: "Test GHA"
    custom_fields: |
      IMAGE_URL:123456789.dkr.ecr.us-east-1.amazonaws.com/service:latest
      BUILD_NUMBER:${{ github.run_number }}

Before

Screenshot 2026-03-13 at 10 11 45 AM

After

Screenshot 2026-03-13 at 10 12 06 AM

Fixes #638
Fixes FD-99

@grace-rehn grace-rehn requested a review from a team as a code owner March 12, 2026 22:42
@grace-rehn grace-rehn requested a review from a team March 13, 2026 00:14
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grace-rehn grace-rehn merged commit bd61d14 into main Mar 13, 2026
9 checks passed
@grace-rehn grace-rehn deleted the grace/fix-custom-field-colon-splitting branch March 13, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Fields - Escape : in value

3 participants