fix(android): run hardware acceleration on UI thread#854
Closed
fadi-george wants to merge 1 commit intomainfrom
Closed
fix(android): run hardware acceleration on UI thread#854fadi-george wants to merge 1 commit intomainfrom
fadi-george wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_enableHardwareAccelerationmethod was callingwindow.setFlags()from the Unity main thread, but this is an Android UI operation that must run on the Android UI thread. This caused aCalledFromWrongThreadExceptionwhich broke SDK initialization, preventing push ID, app ID, and other data from loading.Wraps the
setFlagscall inrunOnUiThreadto run on the correct thread.Test plan
CalledFromWrongThreadExceptionin logcatMade with Cursor
This change is