Skip to content

refactor: make session store operations deterministic with redis support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sammargolis wants to merge 1 commit into
base: feat/authz-note-generation-route
Choose a base branch
from
Open

refactor: make session store operations deterministic with redis support #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions apps/web/src/app/api/transcription/final/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { NextRequest } from "next/server"
import { parseWavHeader, resolveTranscriptionProvider, transcribeWithResolvedProvider } from "@transcription"
import { transcriptionSessionStore } from "@transcript-assembly"
import { writeAuditEntry } from "@storage/audit-log"
import { writeServerAuditEntry, logSanitizedServerError } from "@storage/server-audit"
import { requireAuth } from "@/lib/auth"

export const runtime = "nodejs"

Expand All @@ -13,6 +14,11 @@ function jsonError(status: number, code: string, message: string) {
}

export async function POST(req: NextRequest) {
const auth = await requireAuth(req)
if (!auth) {
return jsonError(401, "unauthorized", "Authentication required")
}

try {
const formData = await req.formData()
const sessionId = formData.get("session_id")
Expand All @@ -22,7 +28,7 @@ export async function POST(req: NextRequest) {
return jsonError(400, "validation_error", "Missing session_id or file")
}

transcriptionSessionStore.setStatus(sessionId, "finalizing")
await transcriptionSessionStore.setStatus(sessionId, "finalizing")

const arrayBuffer = await file.arrayBuffer()
let wavInfo
Expand All @@ -45,11 +51,13 @@ export async function POST(req: NextRequest) {
resolvedProvider,
)
const latencyMs = Date.now() - startedAtMs
transcriptionSessionStore.setFinalTranscript(sessionId, transcript)
await transcriptionSessionStore.setFinalTranscript(sessionId, transcript)

// Audit log: final transcription completed
await writeAuditEntry({
await writeServerAuditEntry({
event_type: "transcription.completed",
org_id: auth.orgId,
user_id: auth.userId,
resource_id: sessionId,
success: true,
metadata: {
Expand All @@ -65,19 +73,22 @@ export async function POST(req: NextRequest) {
headers: { "Content-Type": "application/json" },
})
} catch (error) {
console.error("Final transcription failed", error)
logSanitizedServerError("transcription.final", error)
const resolvedProvider = resolveTranscriptionProvider()
transcriptionSessionStore.emitError(
await transcriptionSessionStore.emitError(
sessionId,
"api_error",
error instanceof Error ? error.message : "Transcription API failure",
)

// Audit log: final transcription failed
await writeAuditEntry({
await writeServerAuditEntry({
event_type: "transcription.failed",
org_id: auth.orgId,
user_id: auth.userId,
resource_id: sessionId,
success: false,
error_code: "transcription_failed",
error_message: error instanceof Error ? error.message : "Transcription API failed",
metadata: {
transcription_provider: resolvedProvider.provider,
Expand All @@ -88,7 +99,7 @@ export async function POST(req: NextRequest) {
return jsonError(502, "api_error", "Transcription API failed")
}
} catch (error) {
console.error("Final recording ingestion failed", error)
logSanitizedServerError("transcription.final.ingest", error)
return jsonError(500, "storage_error", "Failed to process final recording")
}
}
25 changes: 18 additions & 7 deletions apps/web/src/app/api/transcription/segment/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { NextRequest } from "next/server"
import { parseWavHeader, resolveTranscriptionProvider, transcribeWithResolvedProvider } from "@transcription"
import { transcriptionSessionStore } from "@transcript-assembly"
import { writeAuditEntry } from "@storage/audit-log"
import { writeServerAuditEntry, logSanitizedServerError } from "@storage/server-audit"
import { requireAuth } from "@/lib/auth"

export const runtime = "nodejs"

Expand All @@ -13,6 +14,11 @@ function jsonError(status: number, code: string, message: string) {
}

export async function POST(req: NextRequest) {
const auth = await requireAuth(req)
if (!auth) {
return jsonError(401, "unauthorized", "Authentication required")
}

try {
const formData = await req.formData()
const sessionId = formData.get("session_id")
Expand Down Expand Up @@ -56,7 +62,7 @@ export async function POST(req: NextRequest) {
const startedAtMs = Date.now()
const transcript = await transcribeWithResolvedProvider(Buffer.from(arrayBuffer), `segment-${seqNo}.wav`, resolvedProvider)
const latencyMs = Date.now() - startedAtMs
transcriptionSessionStore.addSegment(sessionId, {
await transcriptionSessionStore.addSegment(sessionId, {
seqNo,
startMs,
endMs,
Expand All @@ -66,8 +72,10 @@ export async function POST(req: NextRequest) {
})

// Audit log: segment transcribed successfully
await writeAuditEntry({
await writeServerAuditEntry({
event_type: "transcription.segment_uploaded",
org_id: auth.orgId,
user_id: auth.userId,
resource_id: sessionId,
success: true,
metadata: {
Expand All @@ -83,19 +91,22 @@ export async function POST(req: NextRequest) {
headers: { "Content-Type": "application/json" },
})
} catch (error) {
console.error("Segment transcription failed", error)
logSanitizedServerError("transcription.segment", error)
const resolvedProvider = resolveTranscriptionProvider()
transcriptionSessionStore.emitError(
await transcriptionSessionStore.emitError(
sessionId,
"api_error",
error instanceof Error ? error.message : "Transcription API failure",
)

// Audit log: segment transcription failed
await writeAuditEntry({
await writeServerAuditEntry({
event_type: "transcription.failed",
org_id: auth.orgId,
user_id: auth.userId,
resource_id: sessionId,
success: false,
error_code: "transcription_failed",
error_message: error instanceof Error ? error.message : "Transcription API failed",
metadata: {
seq_no: seqNo,
Expand All @@ -107,7 +118,7 @@ export async function POST(req: NextRequest) {
return jsonError(502, "api_error", "Transcription API failed")
}
} catch (error) {
console.error("Segment ingestion failed", error)
logSanitizedServerError("transcription.segment.ingest", error)
return jsonError(500, "storage_error", "Failed to process audio segment")
}
}
Loading