Skip to content

Comments

refactor/removed lift front end#2704

Open
hongwei1 wants to merge 20 commits intoOpenBankProject:developfrom
hongwei1:refactor/RemoveLiftFrontEnd
Open

refactor/removed lift front end#2704
hongwei1 wants to merge 20 commits intoOpenBankProject:developfrom
hongwei1:refactor/RemoveLiftFrontEnd

Conversation

@hongwei1
Copy link
Contributor

No description provided.

- Change customerType and parentCustomerId fields from String to Option[String] in CommonModel and CustomerDataModel
- Update all bankconnector implementations (Akka, RabbitMQ, Rest, StoredProcedure) to wrap values in Some()
- Update API methods to use Option operations (contains, exists, getOrElse) for type checking
- Update JSON factory serialization to provide default values ("INDIVIDUAL" for customerType, "" for parentCustomerId)
- Update Swagger definition examples to use Some() wrapper for optional fields
- Ensures type safety and prevents null/empty string issues in customer data handling
- Regenerate frozen metadata for RestConnector_vMar2019 test fixture
- Ensure test data reflects current connector behavior and API responses
- Maintain test consistency with recent connector changes
- Implement fallback authentication mechanism to check external user helper when local credentials fail
- Attempt local user authentication first via AuthUser.getResourceUserId()
- Fall back to external authentication via AuthUser.externalUserHelper() if local lookup returns empty
- Extract user from external helper response and map to resource user ID
- Enables seamless authentication across both local and external user sources
…g code

- Remove commented-out duplicate authentication attempt code
- Replace cryptic error messages with descriptive authentication failure reasons
- Update credential validation error to "Failed to authenticate user credentials."
- Update user lookup error to "User account not found in system."
- Update provider mismatch error to "Authentication provider mismatch."
- Enhance error clarity for debugging and user feedback
…ntication

- Remove deprecated Lift snippet components (Login, Nav, OAuthAuthorisation, OpenIDConnect, etc.)
- Delete legacy web UI templates and HTML pages for consent screens and user onboarding
- Remove Font Awesome assets and associated stylesheet dependencies
- Remove debug and development HTML templates
- Update Bootstrap configuration to remove web UI initialization
- Update authentication flow to use modern OpenID Connect implementation
- Consolidate authentication utilities in APIUtil and AuthUser
- Update API constants and v4.0.0 methods to reflect UI removal
- Update sample properties template and README documentation
- Streamline codebase by eliminating obsolete web interface layer in favor of API-first approach
…tion

- Remove OAuth 1.0a implementation (oauth1.0.scala deleted)
- Remove OAuthHandshake dispatcher registration from Boot.scala
- Remove OAuth header detection logic from OBPRestHelper.scala
- Update README.md to remove OAuth 1.0a references and add migration note
- Extract DirectLogin token methods from OAuthHandshake dependency
- Add getConsumerFromDirectLoginToken and getUserFromDirectLoginToken helpers
- Add OAuth1RemovalTest to verify OAuth 1.0a endpoints are no longer available
- Update authentication validation tests to reflect OAuth 1.0a removal
- Simplify authentication flow by consolidating to OAuth 2.0, OIDC, and Direct Login
… with DirectLogin

- Remove ReqData case class and OAuth 1.0a signature generation logic
- Replace OAuth signing with DirectLogin token-based authorization header
- Simplify RequestSigner to use DirectLogin token format instead of OAuth parameters
- Remove OAuth utility methods (encode_%, decode_%, %% operators, callback, sign)
- Delete oauthTest.scala containing OAuth 1.0a test suite
- Delete CreateUserTest.scala OAuth-dependent test
- Update SendServerRequests.scala to remove OAuth signing dependencies
- Consolidate authentication to DirectLogin method for API requests
- Update .gitignore to include media resources directory
- Add ISOCurrencyCodes.xml with comprehensive ISO 4217 currency code mappings
- Include currency names, codes, numeric identifiers, and minor units for all countries
- Source data from official ISO 4217 standard (published 2018-08-29)
- Delete OAuth 1.0a core files (Arithmetics.scala, OauthParams.scala)
- Remove OAuth 1.0a test utilities (OAuthClient.scala, OAuth1RemovalTest.scala)
- Clean up unused OAuth 1.0a dependencies and imports
- Delete obsolete sandbox scripts that relied on OAuth 1.0a
- Update SendServerRequests to remove OAuth 1.0a signing logic
- Remove OAuth 1.0a constants and helper methods from APIUtil
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant