Dev #174
Merged
Dev #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threshold controls Added a ref to the container in ThresholdControls and implemented a useEffect hook to close the panel when clicking outside of it. This enhances user experience by allowing for easier dismissal of the controls.
Updated the text to specify that the time taken for circuit generation may depend on graph complexity, enhancing clarity for users.
…ating_examples Adjusted the dimensions of the sparse tensor in the generate_activating_examples function to ensure it correctly accounts for the maximum index value. This change prevents potential index errors during feature activation generation.
Previously gradient would not flow to upstream input hooks if replacement layers take ln.hook_normalized instead of hook_resid pre or mid as input. Not tested yet. Chances are there will be bugs.
…ow screen experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.