fix: add built in baseline to windows manifest#423
Open
AaryaTalgaonkar wants to merge 1 commit intoOpenVPN:masterfrom
Open
fix: add built in baseline to windows manifest#423AaryaTalgaonkar wants to merge 1 commit intoOpenVPN:masterfrom
AaryaTalgaonkar wants to merge 1 commit intoOpenVPN:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vcpkg.json manifest file required the builtin-baseline to be mentioned. Without that, the code was not getting built using msvc. I checked the msbuild.yml file which is used for building OpenVPN for Windows systems on this repository. I copied the version from there and updated the vcpkg.json.