In connection with #13, changes to setPeriod()#14
Open
oyeb wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
In connection with #13, changes to setPeriod()#14oyeb wants to merge 1 commit intoPaulStoffregen:masterfrom
oyeb wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
* I've tested my additions but NOT on PWM signal generation. I've no means to do that (no scope). * I've taken the liberty to add an example, for testing purposes alone. * See comments in source and let's discuss.
Contributor
Author
|
[I'm jukedude on the forum] :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See forum post for full story.
TL;DR
This PR asks whether we should let the user decide if he wants to do "frequent updates" and get "half the range than in CPWM" or do just basic initialization and get full range from CPWM
-- OR --
as in Race Condition with frequent updates to setPeriod() #13, remove CPWM altogether.
Actually, there's nothing wrong in keeping CPWM ON and doing frequent updates -- it's only that MOD values need to be halved for corrent timing (since frequent updates implies forceful up-counting alone.) [I hope this makes sense... see the forum for explanations]