Return the expected type from the address/transactions/<address> endp…#1108
Merged
Klakurka merged 1 commit intoPayButton:masterfrom Feb 19, 2026
Merged
Conversation
…oint This returns a view of the raw database but the client expects a simplified and preparsed output, which makes more sense. This updates the interface accordingly, using the existing function that is exactly designed for this. This only break the coded added in PayButton/paybutton#617 since the output of the api call was unused before. Test Plan: The api tests are still green.
Fabcien
added a commit
to Fabcien/paybutton
that referenced
this pull request
Feb 19, 2026
This require PayButton/paybutton-server#1108 to work properly. The server PR fixes the returned type of getAddressDetails so we don't need to convert anymore. Test Plan: Run against the updated server, add some logs if desired, and check the payment is successful on mobile.
Klakurka
approved these changes
Feb 19, 2026
Fabcien
added a commit
to Fabcien/paybutton
that referenced
this pull request
Feb 19, 2026
This require PayButton/paybutton-server#1108 to work properly. The server PR fixes the returned type of getAddressDetails so we don't need to convert anymore. Test Plan: Run against the updated server, add some logs if desired, and check the payment is successful on mobile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oint
This returns a view of the raw database but the client expects a simplified and preparsed output, which makes more sense.
This updates the interface accordingly, using the existing function that is exactly designed for this.
This only break the coded added in PayButton/paybutton#617 since the output of the api call was unused before.
Test Plan:
The api tests are still green.