Conversation
should be entries instead of parties on line 125
MGaetan89
reviewed
Nov 19, 2021
| for (int i = 0; i < count ; i++) { | ||
| entries.add(new PieEntry((float) ((Math.random() * range) + range / 5), | ||
| parties[i % parties.length], | ||
| entries[i % entries.length], |
There was a problem hiding this comment.
parties is actually the right one to use here. It is defined in DemoBase
Contributor
There was a problem hiding this comment.
Sorry, this will not work. There is is no PieEntry() constructor, which will take a PieEntry as second parameter
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Jan 1, 2026
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Jan 2, 2026
Contributor
|
This doesn't work. Here is the evidence AppDevNext#635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should be entries instead of parties on line 125
PR Checklist:
PR Description