Open
Conversation
yaugenka
changed the title
Contributor
|
Nice changes, what do you think about this ? #5268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3298, Fixes #2980, Fixes #4640, Fixes #4557, Fixes #3673.
For those who are looking for a workaround solution, have posted one into #3298.
The fix required modification of
AxisRender.ComputeAxisValuesjust forXAxis.In order to avoid code duplication, the following refactoring was done.
ComputeAxisValueswas split intoCompleteAxisInterval(the part which differs for X and Y axis) andComputeAxisValues(the common part). The resulting workflow isX/YAxisRenderer.ComputeAxis->X/YAxisRenderer.CompleteAxisInterval->AxisRender.ComputeAxisValues.