[Shape tools] Reorder toolbar items and hides stroke width and dash buttons when there is no stroke#2019
Merged
cameronwhite merged 7 commits intoPintaProject:masterfrom Mar 5, 2026
Conversation
Probably would be better to create a setter instead of a raw method, but this works. Also, this should probably be refactored in the future anyway, as it's counterintuitive to work with, in comparison to other widgets.
Contributor
Author
|
Pending implementing the same changes to the Freeform Shape tool. Edit: As the Freeform Shape tool inherits from BaseBrushTool, this would require a bigger refactor. Thus, I'm leaving it for a future MR. |
cameronwhite
reviewed
Mar 5, 2026
Member
cameronwhite
left a comment
cameronwhite
left a comment
There was a problem hiding this comment.
Thanks! Trying it out, the rearrangement and hiding of the buttons feels good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On shape tools, like the Rectangle, Rounded Rectangle, Ellipse and Freeform Shape, the "Brush width" parameter only changes the stroke size. Thus, this parameter, as well as the "Dash" parameter, are only applied when there is a stroke. This MR reorders these buttons to the end of the list and hides them when there is no stroke applied. Also renames "Brush width" to "Outline width" for clarity and consistency with the Text Tool.
Fixes #2012
Please squash the commits before merging