Upgrade to .NET 9 and OTAPI Static Hooks for ARM64#254
Merged
hakusaro merged 15 commits intoPryaxis:general-develfrom Jan 26, 2025
Merged
Upgrade to .NET 9 and OTAPI Static Hooks for ARM64#254hakusaro merged 15 commits intoPryaxis:general-develfrom
hakusaro merged 15 commits intoPryaxis:general-develfrom
Conversation
Arthri
approved these changes
Jan 3, 2025
Contributor
Arthri
left a comment
There was a problem hiding this comment.
I have not tested the changes in game, however, the code changes look good. Thank you for working on this
Excluding ARM64 as expected to currently fail / not supported
Avoiding the use of DedServ.
Member
|
I too have not tested in game, but LGTM |
13 tasks
Member
|
@SignatureBeef I merged #253, can you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims for the following:
Considerations that may flow through to a TShock PR (or sooner if desired):
HookEvents.*vs MonoMod RDOn.*ContinueExecution,HookReturnValueMain, Item, NetMessage, Netplay, NPC, WorldGen, Chat.ChatHelper, IO.WorldFile, Net.NetManager, Projectile, RemoteClient, Liquid, Program.Screenshots
Windows x64
MacOS Arm64