fix(StreamExt/ReadBytes): now throws EndOfStreamException when the en…#255
Merged
hakusaro merged 1 commit intoPryaxis:general-develfrom Mar 1, 2025
Merged
Conversation
sgkoishi
approved these changes
Mar 1, 2025
Member
sgkoishi
left a comment
sgkoishi
left a comment
There was a problem hiding this comment.
or perhaps we are moving away from these StreamExt?
| @@ -217,18 +217,12 @@ public static byte[] ReadBytes(this Stream s, int count) | |||
| int num2 = s.Read(array, num, count); | |||
| if (num2 == 0) | |||
Member
There was a problem hiding this comment.
this will throw EndOfStream if the original count == 0, where 0 is somehow expected?
Contributor
Author
There was a problem hiding this comment.
ok let me add a check here
Member
There was a problem hiding this comment.
or use while do instead of do while?
…d of the stream is reached
LaoSparrow
force-pushed
the
streamext-readstring-eos
branch
from
07e4425 to
87792be
Compare
hakusaro
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d of the stream is reached