Test update, remove unnecessary dependencies#11
Test update, remove unnecessary dependencies#11Strnadj wants to merge 3 commits intoRagnarson:masterfrom
Conversation
tests with rails-rspec, remove Rails from dependency and create travis for builds against db and rails versions.
There was a problem hiding this comment.
@seuros That's actually not a typoo, original gem has a dependency the old state_machine, I've just use appraisal to test against both of them (the old state_machine and the new one state_machines), as you can see there is two of gemsets
|
I think you need to use "state_machines-activerecord" instead of just "state_machines", the later don't have the integration. Could you add it to the gemspec ? |
|
Yes, Ive add that, but its lead to these two situations:
|
|
That's actually quite funny :) On localhost test fails because of the errors above, but on Travis: https://travis-ci.org/netbrick/after_commit_queue/jobs/57108047 it works, only problem is a AR observer..., but I think this will be a solution https://github.com/state-machines/state_machines-activemodel-observers |
Hello,
we are using after_commit_queue in several projects, but now we need it outside the rails (for example Sinatra + ActiveRecord or just resque workers with separate gemfile without rails), but there was a problem rails is dependency. So we have to make a few changes: