fix: update CSS selector for comment text styling in zelos ConstantProvider#9362
Open
heliacer wants to merge 4 commits intoRaspberryPiFoundation:mainfrom
Open
fix: update CSS selector for comment text styling in zelos ConstantProvider#9362heliacer wants to merge 4 commits intoRaspberryPiFoundation:mainfrom
heliacer wants to merge 4 commits intoRaspberryPiFoundation:mainfrom
Conversation
1 task
cpcallen
approved these changes
Oct 3, 2025
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Looks good.
BTW: usually we leave the bug report open until the PR that fixes it has been merged, since GitHub will auto-close linked bugs.
Collaborator
|
@gonfunko: can you PTAL at this, to make sure that the CSS change doesn't have some unintended side effect? (In particular I'm wondering if we have any |
gonfunko
approved these changes
Oct 3, 2025
Contributor
|
Looks good to me, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9348
Proposed Changes
Makes font-weight handling consistent for block comment text and workspace comment text in the Zelos renderer
Before (block comment normal weight, workspace comment bold):
After (both comments normal weight):
Reason for Changes
There was an inconsistency in how font-weight was applied:
font-weight: normalThis created a visual mismatch, aligning both ensures consistent styling
Test Coverage
I manually tested by adding block comments and workspace comments in the advanced playground
Documentation
None
Additional Information
None