feat: Add support for displaying contextual menus on icons#9581
Merged
feat: Add support for displaying contextual menus on icons#9581
Conversation
BenHenning
approved these changes
Jan 26, 2026
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
I think this largely looks good but I wouldn't mind taking a pass after the base PR is merged (but will approve so as to not block).
gonfunko
force-pushed
the
icon-context-menus
branch
from
5e7e374 to
1f610a1
Compare
Contributor
Author
|
@BenHenning ready for another look |
BenHenning
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #3568
Proposed Changes
This PR builds on #9580 (it will be rebased once that is merged) to allow icons to display contextual menus. This can be done by simply overriding/implementing
showContextMenu()on anIIconto show a contextual menu with the desired options. By default, icons defer to their parent block's contextual menu, which matches the current behavior when one right clicks on an icon.