Skip to content

feat: Update the DataVolume class to use "storage" as the new default value #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ema-aka-young wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −14
Open

feat: Update the DataVolume class to use "storage" as the new default value #2655

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd88487
feat: Update default value for api_name in DataVolume to 'storage' an…
ema-aka-young Feb 19, 2026
e6e9cb8
Merge branch 'main' into CNV-79539-storage-default
ema-aka-young Feb 19, 2026
f4fded4
Merge branch 'main' into CNV-79539-storage-default
ema-aka-young Feb 23, 2026
f596d5b
Merge branch 'main' into CNV-79539-storage-default
ema-aka-young Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions ocp_resources/datavolume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def __init__(
multus_annotation: str | None = None,
bind_immediate_annotation: bool | None = None,
preallocation: bool | None = None,
api_name: str | None = None,
api_name: str | None = "storage",
Copy link
Collaborator

@rnetser rnetser Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change and the recenlty added warning does mention Default will change to "storage" in a future release. - so it cannot be hidden in a maintanence release

checkpoints: list[Any] | None = None,
final_checkpoint: bool | None = None,
priority_class_name: str | None = None,
Expand Down Expand Up @@ -124,8 +124,7 @@ def __init__(
bind_immediate_annotation (bool, default: None): when WaitForFirstConsumer is set in StorageClass and DV
should be bound immediately.
preallocation (bool, default: None): preallocate disk space.
api_name (str | None, default: None): api used for DV (e.g., "storage", "pvc").
NOTE: Currently defaults to "pvc" if not specified. Default will change to "storage" in a future release.
api_name (str | None, default: "storage"): api used for DV (e.g., "storage", "pvc").
checkpoints (list[Any], default: None): list of DataVolumeCheckpoints for snapshot operations.
final_checkpoint (bool, default: None): indicates whether the current DataVolumeCheckpoint is the final one.
priority_class_name (str, default: None): priority class name for the DataVolume pod.
Expand All @@ -148,17 +147,7 @@ def __init__(
self.multus_annotation = multus_annotation
self.bind_immediate_annotation = bind_immediate_annotation
self.preallocation = preallocation
if api_name is None:
warn(
"The default 'api_name' will change from 'pvc' to 'storage' in a future release. "
"To maintain existing behavior and suppress this warning, "
"explicitly set api_name='pvc' in your constructor call.",
FutureWarning,
stacklevel=2,
)
self.api_name = "pvc"
else:
self.api_name = api_name
self.api_name = api_name
self.checkpoints = checkpoints
self.final_checkpoint = final_checkpoint
self.priority_class_name = priority_class_name
Expand Down