Add Shared Action for System Tests with Playwright#10
Conversation
| - name: Run Yarn Install | ||
| shell: bash | ||
| run: yarn install --immutable | ||
|
|
||
| - name: Cache Playwright Chromium browser | ||
| id: playwright-cache | ||
| uses: actions/cache@v5 | ||
| with: | ||
| path: ~/.cache/ms-playwright | ||
| key: playwright-browsers-${{ runner.os }}-${{ hashFiles('yarn.lock') }} | ||
|
|
||
| - name: Setup Playwright | ||
| if: steps.playwright-cache.outputs.cache-hit != 'true' | ||
| shell: bash | ||
| run: yarn playwright install chromium | ||
|
|
||
| - name: Install Ruby and Gems | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true |
There was a problem hiding this comment.
Push back if you feel that it's overkill, but I wonder if it makes sense to extract this and use it from our other system test action, based on a needs-playwright (or something) input?
So we don't need to try and keep the 2 actions in sync.. Unless you believe they will change for different reasons?
There was a problem hiding this comment.
Yeah, that's probably a good idea
There was a problem hiding this comment.
If you wouldn't mind doing that, I think it would be really valuable. But if it's more work than you signed up for on a Friday. I get that too. I'm going to go ahead and approve now. You can merge when you're ready. With or without that extraction.
| - name: Run Yarn Install | ||
| shell: bash | ||
| run: yarn install --immutable | ||
|
|
||
| - name: Cache Playwright Chromium browser | ||
| id: playwright-cache | ||
| uses: actions/cache@v5 | ||
| with: | ||
| path: ~/.cache/ms-playwright | ||
| key: playwright-browsers-${{ runner.os }}-${{ hashFiles('yarn.lock') }} | ||
|
|
||
| - name: Setup Playwright | ||
| if: steps.playwright-cache.outputs.cache-hit != 'true' | ||
| shell: bash | ||
| run: yarn playwright install chromium | ||
|
|
||
| - name: Install Ruby and Gems | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true |
There was a problem hiding this comment.
If you wouldn't mind doing that, I think it would be really valuable. But if it's more work than you signed up for on a Friday. I get that too. I'm going to go ahead and approve now. You can merge when you're ready. With or without that extraction.
| @@ -1,5 +1,9 @@ | |||
| # RoleModel/actions | |||
|
|
|||
| ## [v3.3.0] Mar 6, 2026 | |||
There was a problem hiding this comment.
make sure to add the reference-link definition to the list of them at the bottom of the file.
2 participants
Our current system-tests action assumes selenium, which is not our default driver anymore