Possiblity to create your own "PluginBase"#175
Open
Spcemarine wants to merge 1 commit intoSEModCommunity:masterfrom
Spcemarine:master
Open
Possiblity to create your own "PluginBase"#175Spcemarine wants to merge 1 commit intoSEModCommunity:masterfrom Spcemarine:master
Spcemarine wants to merge 1 commit intoSEModCommunity:masterfrom
Spcemarine:master
Conversation
Changed PluginBase to IPlugin to make it possible to create your own PluginBase that implements IPlugin.
Contributor
|
What exactly would this do? Can you go into more detail please :) |
Author
|
Well, to detect if a class is a plugin or not the extender goes through the classes and checks if the baseclass implements IPlugin. This allows us to create our own baseclass for plugins. For example my plugins have to open database connections and since I dont want to implement each time I wrote my own baseclass like PluginBase that implements IPlugin and got an exception because it could not be cast to PluginBase. It would just be right if it is IPlugin instead of PluginBase because that is the sense of the interface, isn't it? |
|
As a plugin author, I agree with this change. The PluginBase class is limiting and not necessary when we can implement the IPlugin interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed PluginBase to IPlugin to make it possible to create your own
PluginBase that implements IPlugin.