stm32h5x: fix errors due to deprecated syntax.#49
Open
csanchezdll wants to merge 1 commit intoSTMicroelectronics:openocd-cubeide-r7from
Open
stm32h5x: fix errors due to deprecated syntax.#49csanchezdll wants to merge 1 commit intoSTMicroelectronics:openocd-cubeide-r7from
csanchezdll wants to merge 1 commit intoSTMicroelectronics:openocd-cubeide-r7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trace-configevent is deprecated and prints an ugly error message, recommending usingpre-enableand similar events, for SWO/TPIU. Even if this was not the case, I think this event is not at the right place because access to TPIU registers inCOMMAND_HANDLER(handle_arm_tpiu_swo_enable)is done before the event callback is ignored, and TPIU is not clocked without TRACE_EN so the accesses fail. I discovered this while trying to use SWO in my STH32H5x custom board. The right way is to use apre-eventwhen configuring swo, so either removing this callback definition altogether (as his PR does) or including swo configuration i this file (assstm32h7x.cfgdoes).mem2arrayis deprecated and returns no value. This means the read-modify-write logic instm32h5x_mmwdoes not work. This is only used in two places where reset value is zero, so no real harm is done, but it breaks other potential uses ofstm32h5x_mmw(including the ones which were on thetrace-config, if it was working). This PR changes it to useread_memory, which is current.