Add and example to consume the WebRtcTCPRelayDetectedEvent#43
Add and example to consume the WebRtcTCPRelayDetectedEvent#43david-macpherson wants to merge 33 commits intoScalablePixelStreaming:mainfrom
Conversation
dan-tw
left a comment
dan-tw
left a comment
There was a problem hiding this comment.
Looks good, left some feedback
| }, | ||
| output: { | ||
| filename: '[name].js', | ||
| library: 'spstypescriptexample', |
There was a problem hiding this comment.
Different output name for the library here perhaps?
There was a problem hiding this comment.
Changed the library name
There was a problem hiding this comment.
Given that this is meant as an 'example' -- can we get some detailed commenting on this file and any others telling us what each thing is and how it is used/meant to be used?
There was a problem hiding this comment.
Added some more commenting
|
Just a thought about this PR. Perhaps we could make use of the environment variables on the typescript example to build it with or without the Interested to hear options |
library/src/SPSApplication.ts
Outdated
|
|
||
| // if we have overriden the signalling server URL with a .env file use it here | ||
| if (WEBSOCKET_URL) { | ||
| if (WEBSOCKET_URL != "") { |
There was a problem hiding this comment.
This will fail in prod where WEBSOCKET_URL is being set as undefined:
plugins: [
new webpack.DefinePlugin({
WEBSOCKET_URL: undefined
}),
]…ntend into F_WebRTC-TCP-Stream
…ntend into F_WebRTC-TCP-Stream
2 participants
Relevant components:
Problem statement:
What problem does this PR address?
Solution
How does this PR solve the problem?
Documentation
If you added a new feature or changed an existing feature please add some documentation here.
Or better yet, link to the relevant
/Docsupdate in your PR.Test Plan and Compatibility
What steps have you taken to ensure this PR maintains compataibility with the existing functionality?
Or better yet, link to the unit tests that accompany this PR.