docs(edge-apps): restructure READMEs with consistent format and tables#686
docs(edge-apps): restructure READMEs with consistent format and tables#686nicomiguelino merged 21 commits intomasterfrom
Conversation
- Standardize section ordering across all Edge App READMEs - Convert settings from bullet lists to tables with Setting, Description, Type, and Default columns - Emphasize deployment commands with `bun run deploy` in deployment steps - Simplify and unify Development and Testing sections - Remove excessive detail while preserving essential information
PR Reviewer Guide 🔍(Review updated until commit 089a99e)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 089a99e
Previous suggestionsSuggestions up to commit 635d946
|
There was a problem hiding this comment.
Pull request overview
This pull request standardizes the documentation structure across seven Edge App READMEs, improving consistency and readability. The changes restructure each README to follow a uniform format with Getting Started, Deployment, Configuration, Development, and Testing sections, convert settings from bullet lists to markdown tables, and emphasize the use of bun run deploy for deployment.
Changes:
- Standardized section ordering across all affected Edge Apps
- Converted settings from bullet lists to structured markdown tables with Setting, Description, Type, and Default columns
- Updated deployment commands to consistently use
bun run deployinstead ofscreenly edge-app deploy - Simplified Development and Testing sections to focus on essential commands
- Removed detailed feature descriptions, design notes, and best practices to streamline documentation
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| edge-apps/weather/README.md | Restructured sections, converted settings to table format, updated deployment commands |
| edge-apps/simple-timer/README.md | Converted settings to table format with consistent Type and Default columns |
| edge-apps/qr-code/README.md | Complete restructure with standardized sections, removed Features section, converted settings to table |
| edge-apps/menu-board/README.md | Major simplification removing extensive documentation, standardized structure with settings table |
| edge-apps/grafana/README.md | Restructured sections, removed Features and example configuration, converted settings to table |
| edge-apps/clock/README.md | Converted settings to table format, updated deployment commands, simplified Development section |
| edge-apps/cap-alerting/README.md | Significant simplification removing NWS formatting details and override playlist integration info, standardized structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix theme setting: change type from optional to required
- Fix theme default value from 'dark' to 'light'
- Add missing default values: enable_analytics ('true'), override_locale ('en'), tag_manager_id ('GTM-P98SPZ9Z')
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Restore NWS Text Product Formatting section with period-based forecasts and WWWI format documentation - Fix setting names to match manifest: default_language → language, maximum_alerts → max_alerts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add "Default Menu Items" section documenting the 4 sample pizzas - Add missing currency and display_errors settings from manifest - Fix menu_title type from optional to required to match manifest Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add description explaining integration with Screenly's Playlist API - Add dedicated "Playlist Priority Integration" section with details on using PATCH /v4/playlists endpoint - Document how to use priority parameter to interrupt content during alerts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Apply prettier formatting to improve markdown table alignment Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Persistent review updated to latest commit 089a99e |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Break long line into shorter sentences with bullet points to comply with MD013 linting rule (400 char limit) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Fix headline and url from optional to required - Add default values for all settings (call_to_action, enable_utm, headline, url) - Add missing display_errors setting - Mark enable_utm as advanced Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add display_errors setting from manifest to configuration table Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@nicomiguelino Also added new app in Repo Readme and fix the app order - 7f86395 |
- Remove enable_analytics, tag_manager_id, and sentry_dsn from configuration tables - Keep openweathermap_api_key as it's needed for local development and CLI deployment - Remove "global" designation from openweathermap_api_key type Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add item_X_description, item_X_labels, item_X_name, and item_X_price to configuration table - Remove redundant "Menu Items" subsection - Format table descriptions to wrap at 100 characters Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Change item_X_* to item_XX_* to reflect actual zero-padded implementation - Clarify that XX is 01-25, not 1-25 - Add examples to show correct usage (e.g., item_01_description) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
User description
Summary
bun run deployin deployment stepsAffected Apps
PR Type
Documentation
Description
Standardize Edge App README structure
Add Getting Started and Deployment steps
Convert settings lists into tables
Clarify CAP playlist priority integration
Diagram Walkthrough
File Walkthrough
7 files
Restructure README and update playlist docsConvert configuration docs to settings tableStandardize setup steps and config tableRewrite README and document default itemsAdd standard sections and config tableReplace settings list with markdown tableUpdate deploy commands and configuration table