Conversation
|
Forgot to mention that i needed this patch to add a Also noting that it this extension doesn't nothing for pages with content-type: text/plain (makes sense). |
|
|
||
| $comment = ''; | ||
|
|
||
| if ( !$this->metaPropertyMarkup ) { |
There was a problem hiding this comment.
I am not sure if we need this here too, since this HTML comment is already added via the following lines
SemanticMetaTags/src/OutputPageHtmlTagsInserter.php
Lines 120 to 123 in f33ad92
|
|
||
| private function reqMetaHttpEquivs( $tag ) { | ||
|
|
||
| // If a tag contains a `og:` such as `og:title` it is expected to be a |
There was a problem hiding this comment.
This needs to be adapted. This is the identical comment copied from the following lines:
SemanticMetaTags/src/OutputPageHtmlTagsInserter.php
Lines 135 to 137 in f33ad92
|
@ankostis Thanks a lot for submitting a pull request. I have commented while doing a first check. It will be great if @JeroenDeDauw could make some comments form a programmers perspective, too. |
That is a quick'n dirty implementation to output
<meta http-equiv="...">tags.The above html element gets produces only for those tags in
smtgTagsPropertiesthat exist also in the newsmtgMetaHttpEquivsGLOBALS array.src/OutputPageHtmlTagsInserter.phpfile was modified.