fix(worker): restore unique per-node volume names #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ee498f2c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ode names The deterministic naming from f8caa000 made every node in the same workflow run share one Docker volume name. Parallel branches can overwrite each other's files and cleanup can remove the volume while another branch is still using it. Restore timestamp-based naming in initialize() so each node gets a unique volume. Remove deriveVolumeName() — downstream components (scanners) should receive the volume name from clone-repo's output via the workflow graph instead of deriving it. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
LuD1161
force-pushed
the
fix/restore-unique-volume-names
branch
from
6ee498f to
13672e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tenant-{id}-run-{runId}) removed timestamps, making every node in the same workflow run share one Docker volume nameinitialize()so each node gets a unique volumederiveVolumeName()— scanners should receive the volume name from clone-repo's output via the workflow graph, not derive itTest plan
volumeNamefrom clone-repo output via graph edges