Closed
Conversation
But broken global dashboard as a consequence
Is shown when you're unauthenticated or authenticated as someone other than the one who controls the Pod
Vinnl
approved these changes
Aug 12, 2019
| function buildHomePage (container: HTMLElement, subject: NamedNode) { | ||
| const wrapper = document.createElement('div') | ||
| container.appendChild(wrapper) | ||
| const shadow = wrapper.attachShadow({ mode: 'open' }) |
Contributor
There was a problem hiding this comment.
So the homepage is shown inside the data browser in the area reserved for the Pane, is that correct? I also just realised that Shadow DOM isn't supported in IE11, is that something we're OK with?
Contributor
Author
There was a problem hiding this comment.
The data browser is currently not working with IE at all - so in my mind, it is not something we can prioritize at the moment.
But we should be mindful of this in the future, so glad that you mentioned this.
| refreshTarget: HTMLTableElement; | ||
| } | ||
|
|
||
| export interface SolidSession { |
Contributor
There was a problem hiding this comment.
Time for another PR to DefinitelyTyped, I guess? :)
Contributor
Author
|
This was made obsolete by the changes merged into Reopen if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the dashboard w/global (context-free) panes that Tim introduced in #123 as a pane, that is shown when you're authenticated on a Pod you control.
As a fallback (shown for guests - i.e. unauthenticated users and authenticated users who do not control the Pod they're visiting) we generate a homepage-like view on the fly (based on the index.html that might be removed from Node-solid-server).