Fix loading data from the sync stream in spikeglx#3959
Merged
h-mayorquin merged 2 commits intoSpikeInterface:mainfrom Jun 3, 2025
Merged
Conversation
samuelgarcia
approved these changes
Jun 2, 2025
Member
|
Merci. |
zm711
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR on neo:
NeuralEnsemble/python-neo#1683
the sync channel is separated into its own stream. However, if someone wants to load the stream-sync there is an error:
The reason for this is that stream id is built on the fly for the synch data and therefore is not available in the
neo_reader.signals_info_listso this fails.This PR fixes it by just avoiding this lookup when the sync stream is requested. It also adds a test and removes a test for loading the sync channel as that feature is going to be removed.