Skip to content

STAC-24380: Fix port-forward logic with Rancher URL in kubeconfig #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viliakov merged 1 commit into from
Mar 2, 2026
Merged

STAC-24380: Fix port-forward logic with Rancher URL in kubeconfig #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/clients/k8s/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"net/http"
"net/url"
"os"
"path"
"path/filepath"

appsv1 "k8s.io/api/apps/v1"
Expand Down Expand Up @@ -104,13 +105,14 @@ func (c *Client) PortForwardService(namespace, serviceName string, localPort, re

// PortForwardPod creates a port-forward to a specific pod
func (c *Client) PortForwardPod(namespace, podName string, localPort, remotePort int) (chan struct{}, chan struct{}, error) {
path := fmt.Sprintf("/api/v1/namespaces/%s/pods/%s/portforward", namespace, podName)
reqPath := fmt.Sprintf("/api/v1/namespaces/%s/pods/%s/portforward", namespace, podName)
hostIP := c.restConfig.Host
pfURL, err := url.Parse(hostIP)
if err != nil {
return nil, nil, fmt.Errorf("failed to parse host: %w", err)
}
pfURL.Path = path
// Preserve any existing path prefix (e.g. from Rancher/OpenShift proxy URLs)
pfURL.Path = path.Join(pfURL.Path, reqPath)

transport, upgrader, err := spdy.RoundTripperFor(c.restConfig)
if err != nil {
Expand Down