chore(QTDI-1914): Sample dynamic schema connector. #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement, better clazz location.
…l loaded... to continue...
…:Talend/component-runtime into ypiel/QTDI-1914_sample_connector_dyndeps
# sample-parent/sample-features/dynamic-dependencies/dynamic-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/config/Dependency.java # sample-parent/sample-features/dynamic-dependencies/dynamic-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/service/AbstractDynamicDependenciesService.java
# Conflicts: # sample-parent/sample-features/pom.xml
…st log + add an error messae in returned strings.
…st log + add an error messae in returned strings.
…SPI is not loaded.
…Don't fail if SPI can't be loaded.
…to transmit its dynamic dependencies.
…hSPI connector output records.
…cy-common module.
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive sample connector module demonstrating dynamic dependency loading capabilities. The implementation showcases how to use the @DynamicDependencies annotation with various configuration types (datastore, dataset, and custom configuration) and validates SPI loading from different dependency scopes.
Changes:
- Added new
dynamic-dependenciesmodule with multiple sample connectors demonstrating@DynamicDependenciesfeature - Introduced
DynamicDependenciesConfigurationannotation for marking configuration types that compute dynamic dependencies - Created supporting modules for SPI testing and classloader validation
Reviewed changes
Copilot reviewed 99 out of 110 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sample-parent/sample-features/pom.xml | Added dynamic-dependencies module to the build |
| component-api/src/main/java/.../DynamicDependenciesConfiguration.java | New annotation for marking dynamic dependency configuration types |
| sample-parent/sample-features/dynamic-dependencies/pom.xml | Parent POM defining the dynamic-dependencies module structure |
| sample-parent/sample-features/dynamic-dependencies/README.md | Comprehensive documentation explaining the dynamic dependencies feature and test scenarios |
| sample-parent/sample-features/dynamic-dependencies/*/pom.xml | Module-specific POM files for various sample connectors |
| sample-parent/sample-features/dynamic-dependencies//src/main/java/**/.java | Implementation classes for sample connectors, services, and configuration |
| sample-parent/sample-features/dynamic-dependencies//src/test/java/**/.java | Test classes validating dynamic dependency loading |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...nt/sample/feature/dynamicdependencies/withspi/input/DynamicDependenciesWithSPIInputTest.java
Outdated
Show resolved
Hide resolved
.../main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/config/Connector.java
Outdated
Show resolved
Hide resolved
...t/sample/feature/dynamicdependencies/withDynamicDependenciesConfiguration/config/Config.java
Outdated
Show resolved
Hide resolved
...dk/component/sample/feature/dynamicdependencies/withDataprepRunAnnotation/config/Config.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
https://qlik-dev.atlassian.net/browse/QTDI-1914
Why this PR is needed?
What does this PR adds (design/code thoughts)?