Skip to content

chore(QTDI-2184): replace hardcoded commons-lang3 version with property reference in API test #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxia-talend wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(QTDI-2184): replace hardcoded commons-lang3 version with property reference in API test #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions talend-component-maven-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@
</dependencies>

<build>
<resources>
<resource>
<directory>src/it</directory>
<filtering>true</filtering>
</resource>
</resources>
Comment on lines +150 to +155
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource configuration appears to be duplicating or overriding the default resource directory (src/main/resources). If this is intended to add src/it as an additional resource directory, the configuration should include both the default src/main/resources and the new src/it directory to avoid losing default resources. Consider verifying that this configuration doesn't inadvertently exclude the standard resource directory.

Copilot uses AI. Check for mistakes.
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
2 changes: 1 addition & 1 deletion .../src/it/web/test/tck-component-dependency-api-test/tck_component_dependency_api_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"version": "V11"
},
"host": "${\"server-ip\"}:${\"server-port\"}",
"path": "/api/v1/component/dependency/org.apache.commons:commons-lang3:jar:3.18.0"
"path": "/api/v1/component/dependency/org.apache.commons:commons-lang3:jar:@commons-lang3.version@"
},
"description": "Call using a maven coordinate as id",
"id": "bf2d61ec-73bc-4bab-bdda-3aea33176431",
Expand Down
Loading