chore(QTDI-2184): replace hardcoded commons-lang3 version with property reference in API test#1163
Conversation
…ty reference in API test
There was a problem hiding this comment.
Pull request overview
This PR replaces a hardcoded version string with a Maven property reference in an API test configuration to improve maintainability and consistency across the project.
Changes:
- Replaced hardcoded
commons-lang3version3.18.0with property placeholder@commons-lang3.version@in the API test JSON file - Configured Maven resource filtering for the
src/itdirectory to enable property substitution during build
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tck_component_dependency_api_test.json | Updated API test path to use property placeholder instead of hardcoded version |
| pom.xml | Added resource filtering configuration to enable property substitution in integration test files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <resources> | ||
| <resource> | ||
| <directory>src/it</directory> | ||
| <filtering>true</filtering> | ||
| </resource> | ||
| </resources> |
There was a problem hiding this comment.
The resource configuration appears to be duplicating or overriding the default resource directory (src/main/resources). If this is intended to add src/it as an additional resource directory, the configuration should include both the default src/main/resources and the new src/it directory to avoid losing default resources. Consider verifying that this configuration doesn't inadvertently exclude the standard resource directory.
thboileau
force-pushed
the
lxia/QTDI-2184_fix-hardcode-for-commons-lang3jar
branch
2 times, most recently
from
ab63e4b to
d7c9c6e
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)1 participant
This PR replaces a hardcoded version string with a Maven property reference in an API test configuration to improve maintainability and consistency across the project.
Changes:
Replaced hardcoded commons-lang3 version 3.18.0 with property placeholder @commons-lang3.version@ in the API test JSON file
Configured Maven resource filtering for the src/it directory to enable property substitution during build