Related to Issue #277 - Failing to right click on TreeNode#577
Open
mwbowers wants to merge 1 commit intoTestStack:masterfrom
mwbowers:master
Open
Related to Issue #277 - Failing to right click on TreeNode#577mwbowers wants to merge 1 commit intoTestStack:masterfrom mwbowers:master
mwbowers wants to merge 1 commit intoTestStack:masterfrom
mwbowers:master
Conversation
When attempting to find the framework, once one is found, stop analyzing the ancestors.
|
What you said didn't provide any resolution for how to make TreeNode.RightClick() work. |
Author
|
In my case it was getting to the top parent, which did not have a FrameworkId, and setting the FrameworkId to the parent's (nothing) which caused the error. The change in this PR provides a resolution for this by getting the FrameworkId from the first ancestor that has one. If you're having the same trouble, pull the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After bringing in the previous change of this file, I was able to call the Get method properly (I had been experiencing the same issue identified in Issue #277 ); however, I did have some issues with TreeNodes not being able to right click. With the previous version, the frameId was climbing the entire tree before resolving. Modified to resolve with the FrameworkId of the first ancestor that has one.