Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Mathematics ->
Abs.scala - Removed redundant return keywords, made the whole function inline and fixed issues found in the doc comments
AbsMax.scala - Added the imports for abs function implemented in Abs.scala and fixed issues found in the doc comments
AbsMin.scala - Added the imports for abs function implemented in Abs.scala and fixed issues found in the doc comments
BinaryExponentiation.scala - Removed redundant return keywords and brackets, fixed issues found in the doc comments and refactored the tabs and spaces properly
Fibonacci.scala - Changed numeric type from Int to Long to accommodate for bigger numbers and fixed issues found in the doc comments
FindMax.scala - fixed issues found in the doc comments
FindMin.scala - fixed issues found in the doc comments
GreaterCommonDivisor.scala - changed name to GreatestCommonDivisor [test spec, file and object names], added tailrec annotation and fixed issues found in the doc comments
LinearSieve.scala - Changed numeric type from Int to Long to accommodate for bigger numbers and fixed issues found in the doc comments
PrimeFactors.scala - Removed redundant return keywords and brackets, fixed issues found in the doc comments and refactored the tabs and spaces properly
StreamSieve.scala - Changed numeric type from Int to Long to accomodate for bigger numbers and fixed issues found in the doc comments
Search ->
BinarySearch.scala - Added tailrec annotation
JumpSearch.scala - Removed redundant return keywords
LinearSearch.scala - Removed unnecessary parenthesis
Sort ->
BubbleSort.scala - Changed '0 to array.length - 1' to 'array.indices'
HeapSort.scala - Changed 'var to val' on line 31 and fixed issues found in the doc comments
InsertionSort.scala - Changed '0 to array.length - 1' to 'array.indices'
MergeSort.scala - Fixed a typo on line 30
SelectionSort.scala - Changed '0 to array.length - 1' to 'array.indices' and Changed 'i + 1 to array.length - 1' to 'i + 1 until array.length'