computer_science/recursion/1_factorial: fixed bug where test could fail for 25! despite correct implementation#605
Merged
JoshDevHub merged 1 commit intoTheOdinProject:mainfrom Dec 16, 2025
Conversation
rationale: 18! is the largest factorial less than 2^53-1 (the precision of a double). When testing 25!, there could be rounding errors when the implemented solution was different from the solution provided by TOP, which resulted in the test to fail despite having a correct algorithm. Testing with 18! instead of 25! ensures that there will be no such fail.
JoshDevHub
approved these changes
Dec 16, 2025
Contributor
JoshDevHub
left a comment
JoshDevHub
left a comment
There was a problem hiding this comment.
Awesome! Thank you for fixing this 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
When testing 25!, there could be rounding errors when the implemented solution was different from the solution provided by TOP, which resulted in the test to fail despite having a correct implementation.
This PR
Issue
Closes #604
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder