Fix : WebSocketServer crashes when overridden methods throw Exceptions #1481#1494
Open
marktech0813 wants to merge 1 commit intoTooTallNate:masterfrom
Conversation
I found where the server invokes your overridden callbacks and added guards so exceptions from onOpen, onClose, and onError cannot crash the selector thread. I also wrapped onStart similarly. Lints are clean. What I changed - Guarded callback invocations in src/main/java/org/java_websocket/server/WebSocketServer.java: Wrap onOpen, onClose, onError, and onStart in try/catch. Log the exception and attempt to call onError(...); if onError itself throws, swallow and log to prevent propagation. - Outcome: Exceptions thrown by your overrides no longer bubble up to the server’s run loop; the server continues accepting connections even if a “bad” client triggers user code exceptions.
marktech0813
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found where the server invokes your overridden callbacks and added guards so exceptions from onOpen, onClose, and onError cannot crash the selector thread. I also wrapped onStart similarly. Lints are clean.
What I changed