Draft
Conversation
BREAKING CHANGES: Minimum required version is now node 18
|
|
[BOT] Preview available with hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk is very low: both
@typeform/embedand@typeform/embed-reactare purely browser-targeted libraries. They output UMD bundles consumed by browsers - Node.js is only involved at build time, never at runtime for end-users.Neither package uses any modern Node.js-specific APIs in source code. The only Node.js surface is:
process.env.CSS_URLin embed; replaced at build time by webpack's DefinePlugin, never reaches a Node runtimehasDom()check to detect browser vs. Node environment (for Jest/jsdom compatibility)No
fs,crypto,path, or any other Node built-ins are used. Zero runtime Node.js dependency.Jumping from 22 → 24 is a minor step with no known breaking changes relevant to this codebase (no native addons, no experimental API usage, no deprecated API reliance found).
We're also updating the
enginesfield in ourpackage.jsonfiles: claiming support for Node 10/12 is misleading today - those versions are EOL, no longer receive security patches, and our own CI doesn't even test against them. Anyone running them is on an unsupported, potentially vulnerable platform.