Skip to content

1177 absorb javascript client#1638

Draft
krowvin wants to merge 8 commits intodevelopfrom
1177-absorb-javascript-client
Draft

1177 absorb javascript client#1638
krowvin wants to merge 8 commits intodevelopfrom
1177-absorb-javascript-client

Conversation

@krowvin
Copy link
Collaborator

@krowvin krowvin commented Mar 12, 2026

This is a rough copy from

https://github.com/hydrologicengineeringcenter/cwms-data-api-client-javascript

Will need

  • Plumbed into gradle / made sure JSON swagger spec is updated to pull during the build and not from the URL
  • CI/CD Updated
  • Access added to NPM for this repo

Placing here to work on it for others to see. Will mark reviewers/ready for review later.

#!/usr/bin/env bash

# Set date variable for use in version
printf -v date '%(%Y.%m.%d)T'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use tags for versioning, Look at the various release.yamls. So the version should come through an environment variable or argument.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then again I now see the note in the readme so maybe that's already taken care of.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch scripts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really for local. If you have docker setup. But it also predated me using act for anything.

It required real specific java versions to run it so at one point I decided to use docker to lock down all the build stuff.

Copied it over without much thought to if it needs to stay when it goes fully automated from a PROD release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Absorb javascript client

2 participants