fix(apollo-react): use icon registry icons for resource node toolbar [AG-771]#280
Open
akraminakib wants to merge 1 commit intomainfrom
Open
fix(apollo-react): use icon registry icons for resource node toolbar [AG-771]#280akraminakib wants to merge 1 commit intomainfrom
akraminakib wants to merge 1 commit intomainfrom
Conversation
akraminakib
added
the
dev-packages
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
📦 Dev Packages
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://uipath.atlassian.net/browse/AG-771
Summary
Fixes two bugs in the
ResourceNodetoolbar:Toolbar showing on placeholder nodes — Placeholder items (empty slots) were incorrectly displaying a toolbar as if they were selected resources. The standalone placeholder check had been removed previously, causing the toolbar to render for non-suggestion placeholders. Re-introduced a guard that returns
nullfor placeholder nodes unless they are active suggestions.Inconsistent toolbar icons — Resource node toolbar actions used plain string icon names (
'close','check','delete') which rendered differently from the sticky notes toolbar. Replaced them with<NodeIcon>components using the icon registry (X,check,trashat size 14), matching the pattern already used by sticky notes. Also aligned theExecutionStatusIconsize from 16 → 14 for consistency.Changes
ResourceNode.tsx— Single file change:NodeIconimport from canvas utilsviewmode and placeholder guards into a single early returniconvalues with<NodeIcon>components for reject, accept, and remove actionsTesting
AG-771.mov