Updating instructions to describe how to build with Gradle#10
Open
Thunderforge wants to merge 6 commits intoUrbanCode:masterfrom
Thunderforge:adding-gradle-wrapper-and-instructions-to-build
Open
Updating instructions to describe how to build with Gradle#10Thunderforge wants to merge 6 commits intoUrbanCode:masterfrom Thunderforge:adding-gradle-wrapper-and-instructions-to-build
Thunderforge wants to merge 6 commits intoUrbanCode:masterfrom
Thunderforge:adding-gradle-wrapper-and-instructions-to-build
Conversation
Also bundling the Gradle wrapper so that a consistent version of Gradle is used to build the plugin
Author
|
Looks like Travis-CI is passing on Oracle JDK 8 and Open JDK 7, but failing because installations for Oracle JDK 7 and Open JDK 6 don't exist (at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bundling the Gradle wrapper so that a consistent version of Gradle is used to build the plugin.
The instructions as-is don't describe how to build the plugin since it was migrated to Gradle in version 5. Furthermore, I added
build.finalizedBy distPluginbecause the Readme says you're supposed to be able to build the project in one step, but that wasn't possible with the existing configuration.