Teleport.cs: Check for existence of controllers before accessing them#906
Open
docquantum wants to merge 2 commits intoValveSoftware:masterfrom
Open
Teleport.cs: Check for existence of controllers before accessing them#906docquantum wants to merge 2 commits intoValveSoftware:masterfrom
docquantum wants to merge 2 commits intoValveSoftware:masterfrom
Conversation
When trying to work on a project without an HMD with controllers, the project defaults to 2D Debug mode. However, since the code expects the controllers to exist, it's not able to get past trying to execute haptic feedback which results in teleporting to fail in 2D Debug mode. These changes make sure that the script check for controller existence before trying to access them. This fixes issue ValveSoftware#483
Collaborator
|
Thanks for the pull request from 2 years ago! This will go into the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to work on a project without an HMD with controllers, the
project defaults to 2D Debug mode. However, since the code expects the
controllers to exist, it's not able to get past trying to execute haptic
feedback which results in teleporting to fail in 2D Debug mode. These
changes make sure that the script check for controller existence before
trying to access them.
This fixes issue #483