Skip to content

feat(NodeGrading): Add show/hide toggle for class responses#2282

Merged
breity merged 4 commits intodevelopfrom
cm-show-hide-student-responses
Mar 10, 2026
Merged

feat(NodeGrading): Add show/hide toggle for class responses#2282
breity merged 4 commits intodevelopfrom
cm-show-hide-student-responses

Conversation

@breity
Copy link
Member

@breity breity commented Mar 9, 2026

Changes

  • Add an option to show and hide Class Responses display in the NodeGradingComponent of the Classroom Monitor.
Screenshot 2026-03-09 at 1 15 24 PM Screenshot 2026-03-09 at 1 15 04 PM

Test

  • Make sure toggling visibility for Class Responses works and grading tools work as before.

@breity breity requested a review from hirokiterashima March 9, 2026 20:21
@breity breity self-assigned this Mar 9, 2026
@qltysh
Copy link

qltysh bot commented Mar 9, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: B
...rComponents/nodeGrading/node-grading/node-grading.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we simplify the template this way:

@if (classResponsesVisible) {
  <filter-components
    [components]="components"
    [selectedComponents]="visibleComponents"
    (componentsChange)="setVisibleComponents($event)"
  />
  <a href="#" class="mat-caption" (click)="toggleClassResponses($event)" i18n>Hide</a>
} @else {
  <a href="#" class="mat-caption" (click)="toggleClassResponses($event)" i18n>Show</a>
}

@breity breity merged commit cd6c725 into develop Mar 10, 2026
1 check passed
@breity breity deleted the cm-show-hide-student-responses branch March 10, 2026 16:33
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.215.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants