Skip to content

Fix: Support link padding#534

Open
Takshil-Kunadia wants to merge 2 commits intoWordPress:trunkfrom
Takshil-Kunadia:fix/trac-8147-plugins-support-link-styling
Open

Fix: Support link padding#534
Takshil-Kunadia wants to merge 2 commits intoWordPress:trunkfrom
Takshil-Kunadia:fix/trac-8147-plugins-support-link-styling

Conversation

@Takshil-Kunadia
Copy link

@Takshil-Kunadia Takshil-Kunadia commented Dec 13, 2025

Description

Fixes the Support link/button having incorrect padding on plugin pages.

Trac Ticket: https://meta.trac.wordpress.org/ticket/8147

Problem

The "Support" link on plugin pages (e.g., https://wordpress.org/plugins/sync-content-from-notion) had asymmetric padding, with the right padding missing. This caused the active state to appear visually unbalanced.

Before After
support-button-defect Screenshot 2025-12-13 at 1 57 15 PM

@Takshil-Kunadia Takshil-Kunadia changed the title Title: Fix: Support link padding Fix: Support link padding Dec 13, 2025
@manhphuc
Copy link

Tested on a plugin page and confirmed the Support link padding looks consistent in the active state now.

Minor suggestion: the padding could be simplified to padding: 0.64rem 1.25rem; for readability (same computed values).

@Takshil-Kunadia
Copy link
Author

Thanks @manhphuc for looking into this. Made the change. ✅

@Takshil-Kunadia
Copy link
Author

Hi @dd32, just checking in on this one, happy to rebase or make any changes if needed! 🙂

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props takshil, manhphucofficial, dd32.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Takshil-Kunadia Takshil-Kunadia force-pushed the fix/trac-8147-plugins-support-link-styling branch from 0116533 to 1afcacd Compare February 28, 2026 07:30
@dd32
Copy link
Member

dd32 commented Mar 2, 2026

As this dates back to http://meta.trac.wordpress.org/changeset/5399 I feel like this is intentional.

While the screenshot above clearly shows the padding would be better equal, it's not in the context of the greater page, the purple box added clear shows that the text is right aligned; except the visual download button which is aligned with the text indented like a button should be. The support link is a link, and not a button.

Screenshot 2026-03-02 at 2 12 45 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants