Skip to content

在MacBook通过 Java -jar 启动应用程序时,Thread.currentThread().getContextClassLo…#620

Open
shenghui555 wants to merge 1 commit intoa2aproject:mainfrom
shenghui555:patch-1
Open

在MacBook通过 Java -jar 启动应用程序时,Thread.currentThread().getContextClassLo…#620
shenghui555 wants to merge 1 commit intoa2aproject:mainfrom
shenghui555:patch-1

Conversation

@shenghui555
Copy link

…ader() 可能为 null 或系统类加载器,导致找不到资源,需要显示的指定类加载器。

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…ader() 可能为 null 或系统类加载器,导致找不到资源,需要显示的指定类加载器。
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shenghui555, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

这个拉取请求通过确保在服务加载过程中使用正确的类加载器,解决了在特定部署场景下资源发现失败的问题。此更改提高了应用程序在不同运行环境下的健壮性和兼容性。

Highlights

  • 修复类加载器问题: 在 ServiceLoader.load() 调用中显式指定类加载器,以解决在某些环境下(如MacBook上通过 java -jar 启动)Thread.currentThread().getContextClassLoader() 可能返回 null 或系统类加载器导致资源无法加载的问题。
Changelog
  • client/base/src/main/java/io/a2a/client/ClientBuilder.java
    • 更新了 ServiceLoader.load() 方法,显式传递 ClientBuilder.class.getClassLoader() 作为类加载器参数。
Activity
  • 作者 shenghui555 提交了此拉取请求,旨在解决 ServiceLoader 在特定环境下无法正确加载服务的问题。
  • 拉取请求描述中提到了遵循 CONTRIBUTING 指南、遵循 Conventional Commits 规范、确保测试通过以及更新 READMEs 的要求。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次变更通过在 ServiceLoader.load 方法中显式指定类加载器,解决了在某些环境(如通过 java -jar 启动)下可能出现的资源加载问题。这是一个很好的健壮性改进,可以避免因线程上下文类加载器不正确而导致的 ServiceLoader 失败。代码修改正确且目标明确,我没有发现其他问题。

@kabir
Copy link
Collaborator

kabir commented Feb 3, 2026

@shenghui555 Thank you for the PR, would you be able to translate the commit message and PR text to English?

Also, I think you need to put "fix: " at the front of the PR title to satisfy the "Conventional Commits" job :-)

@ehsavoie
Copy link
Collaborator

ehsavoie commented Feb 5, 2026

Google translation: When launching an application on a MacBook via Java -jar, Thread.currentThread().getContextClassLoader() may return null or the system class loader may not find the resource, requiring explicit specification of the class loader.

@ehsavoie
Copy link
Collaborator

ehsavoie commented Feb 5, 2026

@shenghui555 Could you provide more details about your use case because usually it is better to rely on the TCCL than on the current class classloader (especially when the classpath is modular)

@shenghui555
Copy link
Author

After I start the Agent client service through a Shell script, when I invoke the Agent server via the a2a protocol for the first time on the user interface, the static code block of ClientBuilder.java will be executed. The invocation works normally on Windows, but encounters a Classloader issue on a MacBook.

@ehsavoie
Copy link
Collaborator

ehsavoie commented Feb 6, 2026

May you share your script so that we can take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants