test: Add quality and features TCK tests for JSON-RPC#667
test: Add quality and features TCK tests for JSON-RPC#667lbobinski wants to merge 2 commits intoa2aproject:mainfrom
Conversation
Summary of ChangesHello @lbobinski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and feature coverage of the JSON-RPC transport by implementing stricter data validation and improving the TCK agent's ability to process diverse message components. These changes directly contribute to the 'quality' and 'features' categories of the transport coverage plan. Additionally, it prepares the TCK agent for future transport expansions by configuring it to expose a REST endpoint. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the TCK test coverage for JSON-RPC by enabling 'quality' and 'features' tests. To pass these new tests, changes have been made to improve robustness. This includes adding extra='forbid' to the base Pydantic model to disallow unknown fields, and adding validation logic for message parts in the SUT agent. The SUT agent is also updated to run a REST server alongside the JSON-RPC server. Overall, the changes are good and improve the quality of the test agent. I have a couple of minor suggestions for code cleanup and style.
| # Unwrap RootModel if present to get the actual part | ||
| actual_part = part | ||
| if hasattr(part, 'root'): | ||
| actual_part = part.root |
| task_id=task_id, | ||
| context_id=context_id, |
As per Phase 1 of the plan in @docs/plan_python_639.md
9670b66 to
28c12b3
Compare
Description
This PR enhances the TCK test coverage for the JSON-RPC transport by enabling the 'quality' and 'features' categories in the CI workflow.
This change aligns with Phase 1 of the transport coverage plan outlined in @docs/plan_python_639.md, ensuring the robustness and feature completeness of the existing JSON-RPC implementation before introducing additional transports.
Key changes:
.github/workflows/run-tck.yamlto include test runs with--category qualityand--category featuresfor thejsonrpctransport.Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Partial fix for #639