Add zip file cache validation#256
Merged
pombredanne merged 2 commits intoaboutcode-org:mainfrom Mar 11, 2026
Merged
Conversation
MarcelBochtler
force-pushed
the
bad-zip-file
branch
from
9ef2a44 to
a0e2931
Compare
MarcelBochtler
changed the title
MarcelBochtler
force-pushed
the
bad-zip-file
branch
2 times, most recently
from
ccf48ca to
c752c84
Compare
MarcelBochtler
force-pushed
the
bad-zip-file
branch
from
c752c84 to
90ffc2a
Compare
MarcelBochtler
force-pushed
the
bad-zip-file
branch
15 times, most recently
from
f26de2e to
d905d6f
Compare
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler
force-pushed
the
bad-zip-file
branch
5 times, most recently
from
b3339a1 to
ae2efad
Compare
We've seen corrupted wheel files in Python Inspector's cache leading to `BadZipFile` exceptions. Add additional validation that ensures that files that will be reused from the cache are actual zip files. Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler
force-pushed
the
bad-zip-file
branch
from
616a2f7 to
898ba33
Compare
MarcelBochtler
changed the title
|
@pombredanne: Hi Philippe, a further python topic :) Unfortunately, the PR has been open for 3 months now. This fix is very important to us!! Would it be possible to review it soon or let us know what is still missing or when this would be possible? Thanks! Best regards Kerstin |
pombredanne
approved these changes
Mar 11, 2026
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! ... merging. Note that a good way to bring this up the queue is with the weekly community calls!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.