Conversation
…hains Fixes W-21368901 - Deeply nested allOf schemas (4+ levels) were not displaying all properties in API Console. Changes: - Add _collectAndPropertiesRecursive() method to handle nested allOf - Update _computeProperties() to use recursive collection when allOf present - Circular reference detection with visited Set - Test added in test/product-order-examples.test.js Impact: - Schemas like PXCAppointmentRef now show all properties including date, timeSlot from deeply nested allOf chains - Deduplicates properties by @id to avoid duplicates - Backward compatible: augments existing logic, no breaking changes Related: - Depends on @api-components/api-example-generator@4.4.36
NazaQuintero
previously approved these changes
Mar 3, 2026
…separately - Restored original product-order-minimal*.json (had ProductOrder_FVO tests) - Added new product-order-deep-allof*.json with PXCAppointmentRef for W-21368901 - Updated .gitignore to allow new model files - Updated demo/index.js to include both models - All tests now pass (547 passed, 0 failed)
NazaQuintero
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes W-21368901 - API Console not displaying properties from deeply nested allOf schemas (4+ levels).
Problem
Customer reported missing
dateandtimeSlotfields in PXCAppointmentRef schema. Root cause: ApiTypeDocument only collected direct properties from allOf, missing properties in nested allOf structures.Solution
_collectAndPropertiesRecursive()method to recursively traverse allOf chains_computeProperties()to use recursive collection whenshacl:andis presentTesting
test/product-order-examples.test.jsDependencies
Related
Screen.Recording.2026-03-03.at.5.03.29.PM.mov