detector extracts timestamps from human readable formats#71
Merged
ipmach merged 7 commits intodevelopmentfrom Mar 10, 2026
Merged
detector extracts timestamps from human readable formats#71ipmach merged 7 commits intodevelopmentfrom
ipmach merged 7 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #70
format_time()indetector.pyassumed the Time is Unix timestamp, optionally with colon-separated suffix. It handled this by splitting on : and taking the first segment before casting to float: split(":")[0]This breaks most other time formats containing a colon
12121.12:20(testdata intest_core_detector.py) is not a valid timeformat at allWhat generated this time log? Could this be some custom logging ( like processID.time) ?
Changes:
12121.12:20not a valid timestamp, removed the :20 from the test dataformat_time()now uses the already existing_extract_timestamp()fromTimeFormatHandlerhelper.--> this also now leads to if nothing is parsed, it returns silently 0 instead of error
test_extract_timestamp.pyNote that probably not all possible timeformats are covered with this
Instead of hardcoded list, could consider
dateutil(or similar), introduces python-dateutil dependencyint(dateutil_parser.parse(time).timestamp())and might also not handle all possible formats correctly